search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Add test for PNG tiles #55

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

This PR adds a test case for PNG tiles. The same code for jpg tiles is used for png.

cdeil commented 7 years ago

Nice to see that PNG I/O works out of the box.

I left one inline comment. Otherwise, as discussed on Slack, I would suggest to refactor the tile tests to use tiles from hips-extra as much as possible, and to only leave one test fetching tiles and asserting that they are identical to tiles read locally from hips-extra, so that we rely on @remote_data as little as possible. Note that currently remote_data tests don't run on travis-ci, so this might actually bring up new issues we hadn't noticed before (probably not though).

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 85.758% when pulling b0f8d4daa85e32a07677522f948b7a9925b07ef7 on adl1995:png_support into e6e87472f73704ebee1073dc18c842d392b7385c on hipspy:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.5%) to 86.061% when pulling b0f8d4daa85e32a07677522f948b7a9925b07ef7 on adl1995:png_support into e6e87472f73704ebee1073dc18c842d392b7385c on hipspy:master.

adl1995 commented 7 years ago

@cdeil I just made another commit.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.3%) to 90.854% when pulling 52aa3aaff06f77b34cfffc78280a29df6b7e58fb on adl1995:png_support into e6e87472f73704ebee1073dc18c842d392b7385c on hipspy:master.

adl1995 commented 7 years ago

@cdeil I made a commit fixing the issues discussed earlier.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.3%) to 90.881% when pulling 18fc6b656fe873955c10d7505c207cfed030615f on adl1995:png_support into e6e87472f73704ebee1073dc18c842d392b7385c on hipspy:master.

cdeil commented 7 years ago

Thanks!