search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Remove tile_width from HipsTileMeta #56

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

This PR addresses #54.

cdeil commented 7 years ago

Looks like you forgot to update one test to the API change here: https://travis-ci.org/hipspy/hips/jobs/250275541#L1144

adl1995 commented 7 years ago

@cdeil Please check the latest commit. It addresses the issues discussed during the telecon today.

cdeil commented 7 years ago

Rebase, please.

adl1995 commented 7 years ago

@cdeil just rebased.

cdeil commented 7 years ago

Did you force push after rebasing?

The last commit I see here is dd6e3d9e50e290c3d9c1fe602a10bd5f5f5b9f42 from yesterday.

adl1995 commented 7 years ago

Yes. I also squashed a commit. I see there is a failing Travis CI build. I will update and push again.

adl1995 commented 7 years ago

@cdeil Just updated. Please check.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-5.04%) to 85.843% when pulling 439a5f79eb47b400f09208a76e77d0fc7bb4de0c on adl1995:tile_width into 41bd2ac7b65b5c948507dd83651a0c7cc10abc89 on hipspy:master.

cdeil commented 7 years ago

This is almost ready to go.

I left two minor inline comments, and looking at #54 to fully address it I think it would be nice if you add a test where you read the properties file and assert that the tile width is 256 for this case: https://github.com/hipspy/hips/issues/54#issuecomment-312840189 (and later on also use that for drawing tests)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-5.0%) to 85.886% when pulling 439bd58bc190c9d957ce4fce9e0acf9c45a40537 on adl1995:tile_width into 41bd2ac7b65b5c948507dd83651a0c7cc10abc89 on hipspy:master.

cdeil commented 7 years ago

Thanks!