Closed adl1995 closed 7 years ago
Looks like you forgot to update one test to the API change here: https://travis-ci.org/hipspy/hips/jobs/250275541#L1144
@cdeil Please check the latest commit. It addresses the issues discussed during the telecon today.
Rebase, please.
@cdeil just rebased.
Did you force push after rebasing?
The last commit I see here is dd6e3d9e50e290c3d9c1fe602a10bd5f5f5b9f42 from yesterday.
Yes. I also squashed a commit. I see there is a failing Travis CI build. I will update and push again.
@cdeil Just updated. Please check.
This is almost ready to go.
I left two minor inline comments, and looking at #54 to fully address it I think it would be nice if you add a test where you read the properties file and assert that the tile width is 256 for this case: https://github.com/hipspy/hips/issues/54#issuecomment-312840189 (and later on also use that for drawing tests)
Thanks!
This PR addresses #54.