hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Reformating SimpleTilePainter class #57

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

As discussed during our telecon on July 5th, the SimpleTilePainter class needs to be reformated to exactly outline the steps mentioned in the drawing algorithm. The current suggestions are outlined below:

@tboch @cdeil - If you have any other suggestions, please share.

cdeil commented 7 years ago

SimpleTilePainter should be passed in a list of tiles instead of a single tile

I would suggest that the painter is responsible for all steps, even tile list computation and fetching. Internally it would eventually create a HipsTileCache and call it to fetch and store the tiles, for now it calls out to the compute tiles needed and fetch tiles needed functions.

I.e. it gets initialised just with the user spec of geometry and which HiPS to use (at the moment represented by a HipsSurveyProperties object, and then runs all the steps from the drawing algorithm description.

cdeil commented 7 years ago

Done by @adl1995 in #66 .