search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
12 stars 16 forks source link

Update base_url property in HipsSurveyProperties class #60

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

This PR addresses issue #53.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 86.726% when pulling ab4b9466c76301954ab7ad973e7ea4d60751baae on adl1995:base_url into 39187d0655aef71efc7911eb6b092d63d79cd6d4 on hipspy:master.

adl1995 commented 7 years ago

@tboch I just made some changes. Please review.

adl1995 commented 7 years ago

I made another commit updating the try-except block and adding a test case.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 97.568% when pulling 10ada966037b2a71aec42b3c85a9773d2bab6a48 on adl1995:base_url into 3cd9d60c8d1f723304d351cbdab58644e4886bbe on hipspy:master.

tboch commented 7 years ago

Thanks! PR merged.