search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
12 stars 16 forks source link

Fix tile width height issue #67

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

As pointed out by @tboch in issue #65, the width and height of the HiPS tiles was inverted. This PR will fix the issue.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.613% when pulling c8da07811554febf8914002c2f44b0ab646474bf on adl1995:width_height_issue into e29054cd6c32ff4c61160c198de504dfb06fca23 on hipspy:master.

cdeil commented 7 years ago

I see at http://scikit-image.org/docs/stable/user_guide/numpy_images.html that indeed they have the (row, col), i.e. (height, width) axis order:

screen shot 2017-07-12 at 08 59 47

So yes, this PR looks good to me.

Please fix the high-level docs example here (add tile_format) and show that it works by pasting the image you get here from that example (you can drag and drop PNGs into Github comment fields).

adl1995 commented 7 years ago

@cdeil The high level docs code is now working. Here is the output:

sky

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.613% when pulling af4eb6f7cac27c06f60468912388dd2f33a3b851 on adl1995:width_height_issue into e29054cd6c32ff4c61160c198de504dfb06fca23 on hipspy:master.

cdeil commented 7 years ago

Looks good to me. Thanks!