Closed adl1995 closed 7 years ago
I think I found a way to prevent docs/plot.py
from being collected (and failing) as a doctest.
Add the line doctest_norecursedirs = docs/plot.py
to setup.cfg
at the end of the tool:pytest
section.
My other suggestion would be that you plot the sky image with wcsaxes
, so that it has coordinate axes.
So I think if you limit this PR to getting this image into the high-level docs, this PR could be finalised quickly.
@cdeil I made the changes. Let's see if the test case passes now...
What do you get locally? Please share a screenshot here.
Works for me locally, I get this:
Here it is:
This is looking good, this can go in soon.
I left two inline commments. My last comment would be to maybe change the name of the script a bit from plot.py
to something more specific, at least plot_fits.py
.
Note that already tomorrow, we'll get a second script that plots an RGB image, and then a few more scripts in the docs in the future still.
@cdeil I think this is ready to be merged now.
I worked, image is here: https://hips.readthedocs.io/en/latest/getting_started.html
🎈 🎈 🎈
Just for future reference, in case we discover some bug or change that example, the image at the moment looks like this:
This PR is not ready to be merged. It just shows that the plot for jpg is not in RGB. So, there might be an issue in drawing.