search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
12 stars 16 forks source link

Fix RGB dtype issue #73

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

@cdeil As discussed on Slack, I have updated the dtype so that RGB drawing works fine.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 96.535% when pulling 9f0f7976be3cf5c8f72a4879774c979f7eeb083e on adl1995:jpg_tile_draw_issue into 2ab7f7ae5edad7e1e797fc11a6b7b93b1b0a0285 on hipspy:master.

adl1995 commented 7 years ago

I just updated the docstring. Here is the output image I'm getting:

jpg_out

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 96.543% when pulling 6139a0bf4047b303a01fefb61ef5288de55486c6 on adl1995:jpg_tile_draw_issue into 2ab7f7ae5edad7e1e797fc11a6b7b93b1b0a0285 on hipspy:master.

cdeil commented 7 years ago

@adl1995 - You must have been looking at an outdated image on the docs page. It's all black now: https://hips.readthedocs.io/en/latest//plot_fits.png I'll make a commit in master shortly to fix.

cdeil commented 7 years ago

Follow-up commits in master: 9b52a7a and 60a5d95

cdeil commented 7 years ago

I had to wipe RTD and trigger a completely fresh build, for the plot scripts from the docs build to re-run. It worked https://readthedocs.org/projects/hips/builds/5698160/ and now the images on http://hips.readthedocs.io/en/latest/getting_started.html are correct, except for the last remaining drawing issue #74 .