search

hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
12 stars 16 forks source link

Fix tile corner order for PNG and JPEG #78

Closed cdeil closed 7 years ago

cdeil commented 7 years ago

This PR fixes the tile corner order in drawing for PNG and JPEG tiles.

Mentioned in #74 and also #18 .

I make a few images and they all looked OK now.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 96.782% when pulling 22fdd85dbb5b2c88fda50a72113ea8e9fb3f94fd on cdeil:corner-fix into 524bb4303ae6f1b2a396c83c7d4331ee5d1671d9 on hipspy:master.

cdeil commented 7 years ago

I'm merging this now.

@adl1995 - I think your "draw HiPS tile grid" functionality still doesn't work for PNG and JPEG tiles, because it would need the same fix? Probably the implementation should be changed to plot lines in pixel coordinates, and to re-use this functionality to compute which corner is which from NWES ? Please update the notebook and file an issue with the result and link to the notebook if still not fully OK. And then we can discuss how best to change the implementation to get correct HiPS tile rectangles drawn in all cases.