hipspy / hips

Python library to handle HiPS
https://hips.readthedocs.io
13 stars 16 forks source link

Travis cleanup #9

Closed bsipocz closed 7 years ago

bsipocz commented 7 years ago

This should ultimately address both #3 and #6, but there are still upstream issues. Opening it now as a WIP, so less likely it slips out of my mind.

bsipocz commented 7 years ago

Btw a nice workaround for the pip install issues would be to update the conda-forge build for healpy to get the latest version (rather than 1.9.1). That case it would be built with newer numpies...

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ac73101bc06726c3672084fedeb93553ecb47742 on bsipocz:travis_cleanup into on hipspy:master.

bsipocz commented 7 years ago

Actually I have no idea why the egg_build disappears. It does the same thing when I build the latest hips master on my fork, too (https://travis-ci.org/bsipocz/hips/builds/237675420)

cdeil commented 7 years ago

@bsipocz - Can you please leave the Appveyor build in place? At the moment we don't import healpy yet, so it should be possible.

I think we definitely want to support Windows here, this is a package that many hobby astronomers or schools might like: an easy way to fetch images and catalogs for any part of the sky, and expose it in a form so that it can be analysed with Python.

The functionality we need from healpy here is very limited, and if they don't start supporting Windows soon, I might actually take the time and implement https://github.com/cdeil/healpix and then we use that here instead of healpy.

bsipocz commented 7 years ago

OK, fair enough. To be honest I only checked the installation docs to see whether it's a requirement or an optional one.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 02b312032a5db1bfea80757957d2c2bce1d39805 on bsipocz:travis_cleanup into e223093605b1de014bf2457040e44d54bce2e81a on hipspy:master.

bsipocz commented 7 years ago

(close-reopen: just pushed a fix to ci-helpers, and needed to retrigger travis on this PR)

bsipocz commented 7 years ago

@cdeil - This should be good to go for travis, there's one docs warning left only, I haven't paid much attention to appveyor as it still picks up the healpy dependency from setup.py (obviously you need to make that being an optional dependency). Also you may want to opt in the auto cancellation on travis, so outdated commits get cancelled out of the queue.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 02b312032a5db1bfea80757957d2c2bce1d39805 on bsipocz:travis_cleanup into e223093605b1de014bf2457040e44d54bce2e81a on hipspy:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2088223789a8ff3354bef56c02f409e452d3a77e on bsipocz:travis_cleanup into e223093605b1de014bf2457040e44d54bce2e81a on hipspy:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2088223789a8ff3354bef56c02f409e452d3a77e on bsipocz:travis_cleanup into e223093605b1de014bf2457040e44d54bce2e81a on hipspy:master.

cdeil commented 7 years ago

@bsipocz - https://travis-ci.org/hipspy/hips/jobs/238045310#L1023 ?

For https://travis-ci.org/hipspy/hips/jobs/238045306#L1083 , can you just add this to the toc in index.rst or should I do that in master?

cdeil commented 7 years ago

I didn't know about travis-ci auto-cancel. Thanks! I've activated it for this hips repo and gammapy as well.

bsipocz commented 7 years ago

@cdeil - Yes, they have it for about 6 months now, and just moved it out from beta testing this week. In astropy we use it since early beta times, works quite well.

This is a repo where they announce new stuff: https://github.com/travis-ci/beta-features

bsipocz commented 7 years ago

Also I can do the toc fix tomorrow, also I guess you don't want to deal with astropy 1.0.x compatibility?

cdeil commented 7 years ago

also I guess you don't want to deal with astropy 1.0.x compatibility?

No. Even just supporting Astropy 1.3 or later for this package would be fine.

bsipocz commented 7 years ago

@cdeil - This should be ready now and get a green travis.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b218ffdbd742d955bcae7c3f7331513093065bdd on bsipocz:travis_cleanup into e223093605b1de014bf2457040e44d54bce2e81a on hipspy:master.

cdeil commented 7 years ago

🎉