Closed bsipocz closed 7 years ago
Btw a nice workaround for the pip install issues would be to update the conda-forge build for healpy to get the latest version (rather than 1.9.1). That case it would be built with newer numpies...
Actually I have no idea why the egg_build disappears. It does the same thing when I build the latest hips master on my fork, too (https://travis-ci.org/bsipocz/hips/builds/237675420)
@bsipocz - Can you please leave the Appveyor build in place? At the moment we don't import healpy yet, so it should be possible.
I think we definitely want to support Windows here, this is a package that many hobby astronomers or schools might like: an easy way to fetch images and catalogs for any part of the sky, and expose it in a form so that it can be analysed with Python.
The functionality we need from healpy here is very limited, and if they don't start supporting Windows soon, I might actually take the time and implement https://github.com/cdeil/healpix and then we use that here instead of healpy.
OK, fair enough. To be honest I only checked the installation docs to see whether it's a requirement or an optional one.
(close-reopen: just pushed a fix to ci-helpers
, and needed to retrigger travis on this PR)
@cdeil - This should be good to go for travis, there's one docs warning left only, I haven't paid much attention to appveyor as it still picks up the healpy dependency from setup.py (obviously you need to make that being an optional dependency). Also you may want to opt in the auto cancellation on travis, so outdated commits get cancelled out of the queue.
@bsipocz - https://travis-ci.org/hipspy/hips/jobs/238045310#L1023 ?
For https://travis-ci.org/hipspy/hips/jobs/238045306#L1083 , can you just add this to the toc in index.rst
or should I do that in master?
I didn't know about travis-ci auto-cancel. Thanks!
I've activated it for this hips
repo and gammapy
as well.
@cdeil - Yes, they have it for about 6 months now, and just moved it out from beta testing this week. In astropy we use it since early beta times, works quite well.
This is a repo where they announce new stuff: https://github.com/travis-ci/beta-features
Also I can do the toc fix tomorrow, also I guess you don't want to deal with astropy 1.0.x compatibility?
also I guess you don't want to deal with astropy 1.0.x compatibility?
No. Even just supporting Astropy 1.3 or later for this package would be fine.
@cdeil - This should be ready now and get a green travis.
🎉
This should ultimately address both #3 and #6, but there are still upstream issues. Opening it now as a WIP, so less likely it slips out of my mind.