Add option to create HipsSurveyProperties from survey name

hipspy / hips

Python library to handle HiPS

https://hips.readthedocs.io

12 stars 16 forks source link

Add option to create HipsSurveyProperties from survey name #95

Closed adl1995 closed 7 years ago

adl1995 commented 7 years ago

As outlined in #82 and during the telecon yesterday, I have added the option to create HipsSurveyProperties using a survey name.

@cdeil Currently, this is not implemented:

In addition, we might want to allow the geometry parameter in make_sky_image to be a dict, and if it is, call WCSGeometry.create_from_dict() for the user as a convenience. I.e. this would work:
geometry = dict(target='crab', fov='10 deg', frame='galactic')
make_sky_image(geometry, hips_survey)

Can this be part of a separate PR?

coveralls commented 7 years ago

Coverage increased (+0.5%) to 96.844% when pulling f6a63fac3909326acee37d2b7d44b06736b135e1 on adl1995:WCSGeometry.from_name into 9cef150727e7a0cd12a5e820d87422fdaac9dda5 on hipspy:master.

adl1995 commented 7 years ago

@cdeil I've made the changes. I also marked the tests with remote_data. Hopefully, the build will pass now.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 96.844% when pulling b84b7764564dc9cebac354019e8db1f60a47d27d on adl1995:WCSGeometry.from_name into 9cef150727e7a0cd12a5e820d87422fdaac9dda5 on hipspy:master.

cdeil commented 7 years ago

Thanks!

coveralls commented 7 years ago

Coverage increased (+0.7%) to 97.02% when pulling 09906ec66668c829a9ca0375840e77090d50de2a on adl1995:WCSGeometry.from_name into 9cef150727e7a0cd12a5e820d87422fdaac9dda5 on hipspy:master.