search

hipstas / AudiAnnotate

Workflows for generating AV editions and exhibits using IIIF manifests by HiPSTAS and Brumfield Labs.
https://hipstas.github.io/AudiAnnotate/
Apache License 2.0
15 stars 8 forks source link

project creation fails #201

Closed saracarl closed 2 years ago

saracarl commented 2 years ago

creating a new project fails; it creates the repo but fails on the "replace-topics" step (the very next one) that tags the repo audiannotate.

Error: PUT https://api.github.com/repos/saracarl/beecher-test/topics: 404 - Not Found // See: https://docs.github.com/rest/reference/repos#replace-all-repository-topics

This is the line that is failing: https://github.com/hipstas/AudiAnnotate/blob/master/AudiAnnotateWeb/app/models/project.rb#L22

@benwbrum wonders if we need to update Octokit. Kayleigh created a project not long ago, so perhaps this is a very recent change to Octokit. `

benwbrum commented 2 years ago

I tried this out on my local system (running Octokit 4.21.0), and was not able to duplicate the problem.

When I did a gem update, Octokit was upgraded to 4.22.0, and the problem happened again.

We can either attempt to figure out what's wrong with Octokit, or lock the version to 4.21.

saracarl commented 2 years ago

Production is running 4.21

saracarl commented 2 years ago

The version of Octokit didn't seem to actually affect this issue. Our conclusion was that it was a race condition where the repository hadn't finished being created before we tried to tag it. We added a 5 second delay between the creation and the tagging to resolve this.