Closed zillingworth closed 1 year ago
After fixing #245, I imported the same file and am seeing the related entries on my test site: https://benwbrum.github.io/atomic-age-country/index/policing/
We've just deployed the latest batch of fixes on the server; can you try this file again and see if the problem is still there?
Yes! All annotations are showing up now. But I am still not seeing related entries in the index and receive the error 404 "Page not found :-(" message
It turns out that your repo had an old version of _config.yml
from before we added the indexing code. I've created a pull request that should fix this.
I do see that several of your index terms begin with a space, and don't load any annotations. Is the space intentional? You can see them in the index list because they appear first in alphabetical order: -Achebe
through -whiteness
all appear before Adonis
through whiteness
. Any idea what's going on there? Were the spaces intentional, or accidentally put in the annotation spreadsheet, or is the software inserting them?
Hi Ben! Just to clarify: would the correct way to indicate multiple index entries in one annotation set be: Adonis,whiteness or Adonis, whiteness? On my spreadsheet, I do the latter, but would be totally content to do the former if it works better in AA. I do leave a space between multiple index entries, but would be happy to not do so if it makes this trickier. I may also be misunderstanding the question in which case please feel free to clarify in today's meeting.
Zoe Bursztajn-Illingworth, PhD Digital Humanities Postdoctoral Fellow Department of English The University of Texas at Austin
On Thu, Oct 20, 2022 at 11:04 AM Ben W. Brumfield @.***> wrote:
It turns out that your repo had an old version of _config.yml from before we added the indexing code. I've created a pull request that should fix this.
I do see that several of your index terms begin with a space, and don't load any annotations. Is the space intentional? You can see them in the index list because they appear first in alphabetical order: -Achebe through -whiteness all appear before Adonis through whiteness. Any idea what's going on there? Were the spaces intentional, or accidentally put in the annotation spreadsheet, or is the software inserting them?
— Reply to this email directly, view it on GitHub https://github.com/hipstas/AudiAnnotate/issues/248#issuecomment-1285808782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2GGXYGBQRTY5UNKC7QD33WEFURXANCNFSM6AAAAAAQ5ZHEBA . You are receiving this because you authored the thread.Message ID: @.***>
Hi Zoe, Oh wow. We do separate on punctuation but not whitespace, so foo,bar
should produce foo
and bar
while foo, bar
will produce foo
and _bar
. I'd say it "works as designed", but there's no way I'd ever train myself not to put a space after punctuation. (I still put two spaces after a period, too!)
I'll modify the code to discard leading whitespace on index terms while we're processing uploaded annotation files, to eliminate this very likely problem.
Fix deployed, if you'd like to try it out @zillingworth
Woo hoo! I merged the pull request and it works fabulously. Thank you, Ben and Sara!
See you soon,
Zoe
Zoe Bursztajn-Illingworth, PhD Digital Humanities Postdoctoral Fellow Department of English The University of Texas at Austin
On Thu, Oct 20, 2022 at 1:49 PM Sara Brumfield @.***> wrote:
Fix deployed, if you'd like to try it out @zillingworth https://github.com/zillingworth
— Reply to this email directly, view it on GitHub https://github.com/hipstas/AudiAnnotate/issues/248#issuecomment-1285993734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2GGX4SVYYCHQQ6VAW3YQTWEGH5LANCNFSM6AAAAAAQ5ZHEBA . You are receiving this because you were mentioned.Message ID: @.***>
Describe the bug In my indexed annotations, while the indexed terms, like "policing," appear to be hyperlinked when you click on indexed term there is no collection of related annotations and you receive an error message
To Reproduce Steps to reproduce the behavior:
Expected behavior A collection of annotations related to the index entry on the next page
Screenshots
Additional context Add any other context about the problem here.