hipstas / AudiAnnotate

Workflows for generating AV editions and exhibits using IIIF manifests by HiPSTAS and Brumfield Labs.
https://hipstas.github.io/AudiAnnotate/
Apache License 2.0
15 stars 8 forks source link

Annotations won't process #264

Open tanyaclement opened 1 year ago

tanyaclement commented 1 year ago

Tried to upload these annotations but it throws an error. Ellison.txt

Project: https://github.com/tanyaclement/ellison_test

tanyaclement commented 1 year ago

I tried again. Here's the new repository: https://github.com/tanyaclement/Ellison_Test3 The annotations are attached. and the error: Showing /home/audiannotate/audi-annotate/AudiAnnotateWeb/app/views/items/show.html.erb where line #123 raised:

No route matches {:action=>"delete_annotation_layer", :controller=>"items", :layer=>"", :repo_name=>"Ellison_Test3", :slug=>"ellison_test3", :user_name=>"tanyaclement"}, missing required keys: [:layer]

    <% @item.canvases.each do |canvas| %>
    <% canvas.annotation_pages.each do |page| %>
      <%= page.label %> <%= link_to("Delete", delete_annotation_layer_path(@item.user_name, @item.repo_name, @item.slug, page.label)) %><br/>
    <% end %>
  <% end %>
  <h3> Annotation Files </h3>

Ellison.txt

benwbrum commented 1 year ago

The source of the problem was a layer column with blank values. We need to figure out what the right behavior ought to be when we encouter these. Current proposal is to automatically label them as unlabeled.