search

hipster-labs / jhipster-daily-builds

:construction_worker: :rocket: Additional builds for generator-jhipster repository
Apache License 2.0
19 stars 25 forks source link

update ci using npm commands instead of script #131

Closed Tcharl closed 2 years ago

Tcharl commented 2 years ago

related to https://github.com/jhipster/generator-jhipster/pull/18776#issuecomment-1142167225

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Tcharl commented 2 years ago

@DanielFran I tried to fix the script update using standard npm commands like we have in the generator. I absolutely don't know how this repo works: can you please guide me (maybe enriching the contributing.md)?

DanielFran commented 2 years ago

@pascalgrimaud can you review please (cannot merge)

pascalgrimaud commented 2 years ago

Too late, it has been merged, anyway, we'll see the results soon :-)

mshima commented 2 years ago

Non jdl samples looks ok. The jdl samples will fail, they are microservices samples. But I think it’s time to migrate them to workspaces.

Tcharl commented 2 years ago

@mshima you take it? I don't know how workspace + ci works. I'm really interested by the review, so that I'll be able to reproduce