search

hipster-labs / jhipster-daily-builds

:construction_worker: :rocket: Additional builds for generator-jhipster repository
Apache License 2.0
19 stars 25 forks source link

Update Ubuntu Image in all Pipelines #27

Closed SudharakaP closed 4 years ago

SudharakaP commented 4 years ago

This updates the Ubuntu VM image to latest in all daily build pipelines.

Fixes https://github.com/jhipster/generator-jhipster/issues/10662

vishal423 commented 4 years ago

how about using ubuntu-latest tag to ensure we always remain on latest LTS?

SudharakaP commented 4 years ago

@vishal423 : I was contemplating about this for a while but then thought what if they update their ubuntu-latest to 20.06 or whatever the next LTS version is; or I am not sure whether they guarantee ubuntu-latest is always a LTS version either. It might give us unintended side effects? :smile:

In either case I am okay with this change; it's just me choosing fixed version over the unfixed ubuntu-latest tag.

@pascalgrimaud : What do you think? If you also like ubuntu-latest instead, I'll go ahead and change it. :smile:

vishal423 commented 4 years ago

@SudharakaP, I believe support should always be LTS across CI providers. There is a risk of the introduction of breaking changes with LTS upgrades (like seen on Travis), but, I don't see that as a big issue.

pascalgrimaud commented 4 years ago

Yes, we should keep and use LTS, to be consistent between our official Docker image, DevBox, CI etc

pascalgrimaud commented 4 years ago

let's give a try ! thanks @SudharakaP !

SudharakaP commented 4 years ago

@pascalgrimaud : Thanks for merging; but what @vishal423 is suggesting is to always use ubuntu-latest instead of fixing it to ubuntu-18.04 which is what I have done. What approach do you prefer? I can change it if you think ubuntu-latest is better. :smile:

pascalgrimaud commented 4 years ago

I'd prefer consistency:

For NodeJS, we suggest to our user to always use Node LTS.

So I think it's better for our user to stay on Ubuntu 18.04 LTS.

vishal423 commented 4 years ago

If I am not wrong, then, current CI providers support only LTS and ubuntu-latest tag will always point to latest LTS.


Cheers,
Vishal

On Tue, Oct 22, 2019, 4:54 PM Pascal Grimaud <notifications@github.com>
wrote:

> I'd prefer consistency:
>
>    - Docker image:
>    https://github.com/jhipster/generator-jhipster/blob/master/Dockerfile#L1
>    - DevBox:
>    https://github.com/jhipster/jhipster-devbox/blob/master/Vagrantfile#L2
>
> For NodeJS, we suggest to our user to always use Node LTS.
>
> So I think it's better for our user to stay on Ubuntu 18.04 LTS.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/hipster-labs/jhipster-daily-builds/pull/27?email_source=notifications&email_token=AD2BV4MGDF3LOT34FRW3ADDQP3PHLA5CNFSM4JDJW5ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB5MGDQ#issuecomment-544916238>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AD2BV4LG3RP7HG26MNMCQYTQP3PHLANCNFSM4JDJW5ZA>
> .
>