search

hipster-labs / jhipster-daily-builds

:construction_worker: :rocket: Additional builds for generator-jhipster repository
Apache License 2.0
19 stars 25 forks source link

Couchbase: disabled #46

Closed pascalgrimaud closed 4 years ago

pascalgrimaud commented 4 years ago

Disabled at https://github.com/hipster-labs/jhipster-daily-builds/commit/f5dbe944f0ac606c90b8617fa07898d8e8ac40e6

The integration tests are too flatky. See :

cc @tchlyah -> as you're our main contributor on Couchbase cc @SudharakaP -> as I know you already spent a lot of time on this

SudharakaP commented 4 years ago

@pascalgrimaud : Let me take another look as well; I think we didn't have a final solution the last time. :smile:

pascalgrimaud commented 4 years ago

@SudharakaP : don't spend time on this, I'm pretty sure it will be fixed soon See https://github.com/testcontainers/testcontainers-java/pull/2491

SudharakaP commented 4 years ago

Thanks for letting me know. :smile:

On Sun, Apr 5, 2020 at 5:09 AM Pascal Grimaud notifications@github.com wrote:

@SudharakaP https://github.com/SudharakaP : don't spend time on this, I'm pretty sure it will be fixed soon See testcontainers/testcontainers-java#2491 https://github.com/testcontainers/testcontainers-java/pull/2491

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hipster-labs/jhipster-daily-builds/issues/46#issuecomment-609406060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC64D7NSC7OAPLYL7ZHLXIDRLBYGRANCNFSM4LV62YIQ .

DanielFran commented 4 years ago

@pascalgrimaud should we disable also couchbase on webflux workflow in main generator?

pascalgrimaud commented 4 years ago

@DanielFran : if it failed a lot, yes

SudharakaP commented 4 years ago

https://github.com/testcontainers/testcontainers-java/pull/2491 is now merged and they released a new version https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0. But I don't see it on sonatype yet. Does it take some time before it's available? :thinking:

cc: @bsideup

SudharakaP commented 4 years ago

Ah now it's available. So I've went ahead and updated it; we shall see if this fixes our problems. :smile:

EDIT: I need to do some more updates since the api seems to have changed. Will do it soon. :smile:

SudharakaP commented 4 years ago

I've upgraded testcontainers and adjusted the Couchbase testing to conform to the new api. Please let me know if you see any issues. :smile:

bsideup commented 4 years ago

@SudharakaP I hope the change was painless :) Please let us know if you experience any issues with the new implementation 👍

SudharakaP commented 4 years ago

@bsideup ; Thanks Sergei. :smile: Yes it wasn't difficult. We will soon see how the new implementation works when the daily builds starts to run. :smile: