search

hipster-labs / jhipster-daily-builds

:construction_worker: :rocket: Additional builds for generator-jhipster repository
Apache License 2.0
19 stars 25 forks source link

Compute default JAVA_HOME instead of hard-coding it when using JDK 11 #9

Closed pvliss closed 5 years ago

pvliss commented 5 years ago

After commit https://github.com/hipster-labs/jhipster-daily-builds/commit/3958fc3767a35fadb6936bdefcea41c6551f063a to properly support JDK 11 it seems that some builds fail, e.g: See ms-ngx-gateway-eureka-oauth2 at https://dev.azure.com/hipster-labs/jhipster-daily-builds/_build/results?buildId=3139.

Although the paths seem to be the same and that is kind of confusing, changing from a fixed path to a calculated one seems to fix the problem (see build from my branch here). In my opinion its also better to use a calculated path instead of a fixed one.

Also now echoing JAVA_HOME to 01-display-configuration.sh to aid debugging a bit

pascalgrimaud commented 5 years ago

thanks, maybe we should do the same for main generator-jhipster ?

pvliss commented 5 years ago

Yes, I believe so, if you also agree of course

pascalgrimaud commented 5 years ago

yes, I think it's a good idea !