search

hipster-philology / pandora

A Tagger-Lemmatizer for Natural Languages
MIT License
9 stars 4 forks source link

Updated requirements and added col_pos and col_lemma config options. #106

Closed peterdekker closed 6 years ago

peterdekker commented 6 years ago

I added configparser to the requirements.

I added col_pos and col_lemma to the possible options in the config file. With the col_pos and col_lemma config options, the user can set which column from the input file should be read as POS tag and which as lemma. If the options are omitted, it defaults to col_pos=2 and col_lemma=1.

Jean-Baptiste-Camps commented 6 years ago

Hey, Many thanks for your pull request. If you add col_pos and col_lemma, you should probably add a col_morph as well (with default to 3).

PonteIneptique commented 6 years ago

There is also a conflict with the latest merge :) Sorry !

peterdekker commented 6 years ago

Thanks for your comments! I merged with the main repository and added the col_morph argument.

Unfortunately, Travic CI shows there is an error when using the PyTorch backend. This error only occurs with the current PyTorch version on pip, not with my local PyTorch version. It should be fixed by using the latest PyTorch source code: https://github.com/pytorch/pytorch/issues/4380

peterdekker commented 6 years ago

@PonteIneptique @Jean-Baptiste-Camps Do you think my pull request could be merged?

PonteIneptique commented 6 years ago

Hey @pdekker12 ! I'll test it locally next Monday, I am truly sorry for not taking care of this earlier.

peterdekker commented 6 years ago

Thanks, no problem!

PonteIneptique commented 6 years ago

Thanks !