search

hipster-philology / pandora

A Tagger-Lemmatizer for Natural Languages
MIT License
9 stars 4 forks source link

Printing or exporting score dict should be done outside of evaluation and test #28

Closed PonteIneptique closed 7 years ago

PonteIneptique commented 7 years ago

Just using this outside would allow for lighter API and centralized "logging". I can see the use of an export to csv for example.

mikekestemont commented 7 years ago

I agree that through logging we could better control where this stuff gets shown, but by default I would keep it visible during training.

On 25 Sep 2017, at 09:17, Thibault Clérice notifications@github.com wrote:

Just using this outside would allow for lighter API and centralized "logging". I can see the use of an export to csv for example.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

PonteIneptique commented 7 years ago

Completely agree.

Le 25 sept. 2017 9:34 AM, "Mike Kestemont" notifications@github.com a écrit :

I agree that through logging we could better control where this stuff gets shown, but by default I would keep it visible during training.

On 25 Sep 2017, at 09:17, Thibault Clérice notifications@github.com wrote:

Just using this outside would allow for lighter API and centralized "logging". I can see the use of an export to csv for example.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hipster-philology/pandora/issues/28#issuecomment-331800236, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1yZkL9dpCOFzuwyXHDb9Z-WuBsSqFYks5sl1eXgaJpZM4PiS7o .

PonteIneptique commented 7 years ago

I think get_score_dict should get fed to a output class that could : print, log, export csv of stats. This would also allow for less modifications on the long term in tagger.py

mikekestemont commented 7 years ago

fine with me

On Mon, Sep 25, 2017 at 10:25 AM, Thibault Clérice <notifications@github.com

wrote:

I think get_score_dict should get fed to a output class that could : print, log, export csv of stats. This would also allow for less modifications on the long term in tagger.py

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hipster-philology/pandora/issues/28#issuecomment-331811219, or mute the thread https://github.com/notifications/unsubscribe-auth/AELJL9W-AY8YhHMgE9rFghnPlnyBysKkks5sl2NhgaJpZM4PiS7o .