hipster-philology / pyrrha

A language-independent post-correction app for POS-tagging and lemmatization
https://pyrrha.huma-num.fr
MIT License
27 stars 16 forks source link

Pyrrha Localization : Language bo_CN #284

Closed Lungsangg closed 2 years ago

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2299817444

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Changes Missing Coverage Covered Lines Changed/Added Lines %
app/init.py 43 44 97.73%
app/ext_config.py 5 6 83.33%
app/models/user.py 2 3 66.67%
<!-- Total: 50 53 94.34% -->
Files with Coverage Reduction New Missed Lines %
app/main/views/tokens.py 1 31.6%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 2267985104: 0.2%
Covered Lines: 1352
Relevant Lines: 2626

💛 - Coveralls
Lungsangg commented 2 years ago

I spotted many non translated things. Is it intentional ?

Yes @PonteIneptique , there are still lots of non translated things because right now I dont have the exact translation word for them. But if it's okay, i can mark and extract all the remaining translatable strings in message.po :)

PonteIneptique commented 2 years ago

I spotted many non translated things. Is it intentional ?

Yes @PonteIneptique , there are still lots of non translated things because right now I dont have the exact translation word for them. But if it's okay, i can mark and extract all the remaining translatable strings in message.po :)

Yup, I think it would be good to at least have everything in extracted, even if the translation is incomplete. This will allow for only working on message.po in the future :)

Lungsangg commented 2 years ago

I spotted many non translated things. Is it intentional ?

Yes @PonteIneptique , there are still lots of non translated things because right now I dont have the exact translation word for them. But if it's okay, i can mark and extract all the remaining translatable strings in message.po :)

Yup, I think it would be good to at least have everything in extracted, even if the translation is incomplete. This will allow for only working on message.po in the future :)

Okay ! i am on it :)

Lungsangg commented 2 years ago

Hello @PonteIneptique, how are you? Do you think its possible to accept the PR and add the user preference. Because we have a #big conference on Tibetan digital humanities during next week in Prague. We are hoping we can share Pyrrha with our community. We will finish translating all the remaining strings in Tibetan(bo_CN) by the end of this week. Thank you for your help :)

PonteIneptique commented 2 years ago

Hey @Lungsang-bod , I was actually waiting for your "go" :) I don't know if I'll have the time to review and correct by next week, but I'll try :)

Lungsangg commented 2 years ago

Thank you :)

PonteIneptique commented 2 years ago

Hey @Lungsang-bod , I am currently applying to different jobs and it's taking me more time than expected, as I also need to do my regular job. I promise you it'll be done this summer :)

Lungsangg commented 2 years ago

Sure @PonteIneptique, in the meantime we will push the translated strings in the PR. Please have a look when time permits you. Wishing the best for your new job :)

PonteIneptique commented 2 years ago

I'll try to deal with this tomorrow, if I can. By the way, have you and your team published any paper I could see about what you do with Pyrrha ? :)

PonteIneptique commented 2 years ago

@Lungsang-bod I reworked your PR in https://github.com/hipster-philology/pyrrha/pull/285 so that it includes the necessary bits.

Can you check that it works for you ?

By the way, if you need a variable in a template, you can use the following snippet:

{{_("lemma were correct from lemmatization. It means you corrected %(count)s lemma.", count=stats.lemma_count)}}

https://github.com/hipster-philology/pyrrha/blob/0f6b01f4ee171affb3f20f01691bb54fead943d1/app/templates/main/corpus_info.html#L57

For future message upgrades, please check the readme.md but basically run

python manage.py translate update
# Change the translation and then do
python manage.py translate compile

and please commit with prefix (i18n/bo_CN) and then your message

Finally, you might need to run

python manage.py db-upgrade user-language

as I modified the models :)

Lungsangg commented 2 years ago

I'll try to deal with this tomorrow, if I can. By the way, have you and your team published any paper I could see about what you do with Pyrrha ? :)

I will ask my team if any paper is published regarding what we do with Pyrrha and will let you know :)