search

hipstersmoothie / storybook-dark-mode

A storybook addon that lets your users toggle between dark and light mode.
MIT License
435 stars 56 forks source link

Syntax error in configuration #153

Closed bilo-io closed 2 years ago

bilo-io commented 3 years ago

Hey so, I think there is a syntax error in the README.md to set up this addon which would be corrected with the following:

- export parameters = {
+ export const parameters = {
    // Override the default dark theme
    darkMode: {

image

  • I may be wrong in that this is now possible with a later version of ECMAscript, or perhaps something specific to Storybook?

  • However, when I used the code suggestion in the README.md the code would not compile!

  • This might be an oversight, but let me know in case there's something I'm not aware of ...

  • Otherwise please update ... for the community

  • I can also create a PR 🤷

hipstersmoothie commented 3 years ago

Looks to be! make a pr and I'll merge

hipstersmoothie commented 2 years ago

:rocket: Issue was released in v1.0.9 :rocket: