search

hipstersmoothie / storybook-dark-mode

A storybook addon that lets your users toggle between dark and light mode.
MIT License
439 stars 56 forks source link

Storybook 8 #251

Closed dartess closed 6 months ago

dartess commented 7 months ago

it looks like it just works. I tested this in examples and in my main project.

Closed https://github.com/hipstersmoothie/storybook-dark-mode/issues/250

dartess commented 7 months ago

I did not change the version in package and did not update the changelog

bryanjtc commented 6 months ago

@hipstersmoothie Can you review and merge this? 8.0 has been released.

hipstersmoothie commented 6 months ago

Just need to get the version updated here @dartess

dartess commented 6 months ago

@hipstersmoothie done

hipstersmoothie commented 6 months ago

Looks like ci needs to be updated since storybook dropped support for node 16

dartess commented 6 months ago

I just tried to up the version. But I'm not familiar with GitHub workflow.

dartess commented 6 months ago

I checked it in my repository - there are no errors, but there are warnings. I'll try to fix them, but it doesn't seem to be critical.

dartess commented 6 months ago

@hipstersmoothie Now everything will be ok, except for two warnings. But it seems it will be safe to update to update actions. After this there are no warnings. I can do it here or in a separate PR later, so as not to slow down the release.

sshmaxime commented 6 months ago

@dartess I think you are better off doing this in this PR considering it's a pretty small thing. Thanks a lot for your PR 🙏

github-actions[bot] commented 6 months ago

:rocket: PR was released in v4.0.0 :rocket:

hipstersmoothie commented 6 months ago

Thanks @dartess!