hiqdev / asset-packagist

Asset Packagist
https://asset-packagist.org
BSD 3-Clause "New" or "Revised" License
247 stars 24 forks source link

Colon in npm dependency name causing installation failure #133

Closed kasutajaimin closed 1 year ago

kasutajaimin commented 3 years ago

The following dependencies of https://asset-packagist.org/package/npm-asset/europeana--media-player

...
  "dependencies": {
    "@iiif/iiif-av-component": "github:Noterik/iiif-av-component#build2",
    "@iiif/manifold": "github:Noterik/manifold#build",
...

are causing installation failure

>composer require npm-asset/europeana--media-player

Using version ^0.7.6 for npm-asset/europeana--media-player
./composer.json has been updated
Running composer update npm-asset/europeana--media-player
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires npm-asset/europeana--media-player ^0.7.6 -> satisfiable by npm-asset/europeana--media-player[0.7.6].
    - npm-asset/europeana--media-player 0.7.6 requires npm-asset/github:noterik/iiif-av-component dev-build2 -> could not be found, it looks like its name is invalid, ":" is not allowed in package names.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
mstenta commented 3 years ago

We ran into this issue as well.

I wonder if it is actually less about the "colon in npm dependency name" and more generally about a lack of support for GitHub dependencies in asset packagist?