search

hirak / prestissimo

composer parallel install plugin
MIT License
6.18k stars 170 forks source link

Use authorization: token header for Github authentication #211

Closed andytson-inviqa closed 4 years ago

andytson-inviqa commented 4 years ago

Fixes GitHub deprecated query param authentication #210

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.2%) to 81.773% when pulling fbc5e00c551c039d6fe5832f74e3df196abd36f2 on andytson-inviqa:feature/github-authorization-header into 01bed92c45e84d01a96f5d15c6e49958cbd57f36 on hirak:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.2%) to 81.773% when pulling 315454c0d6a6c8f42e36eaea140697be13c5ef47 on andytson-inviqa:feature/github-authorization-header into 01bed92c45e84d01a96f5d15c6e49958cbd57f36 on hirak:master.

vkarampinis commented 4 years ago

@hirak any plans to merge this PR. We are getting a lot of mails from GitHub complaining about the access_token on parameters.

On February 12th, 2020 at 08:03 (UTC) your personal access token (jenkins) using Composer/1.9.3 (Linux; 4.14.146-93.123.amzn1.x86_64; PHP 7.2.22) was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/xxxx/zipball/xxxx

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

Composer already made a fix for that on version 1.9.3

hirak commented 4 years ago

Thanks