search

hirak99 / yabsnap

Btrfs Scheduled Snapshot Manager for Arch
Apache License 2.0
65 stars 2 forks source link

PKGBUILD according guidelines #18

Closed nebulosa2007 closed 1 year ago

nebulosa2007 commented 1 year ago

I have updated PKGBUILD using this article.

New PKGBUILD and the install file.

Why? Because, it's not quite right to build package through bash script - it cause errors in future like #17 and other mistakes with permission of files (e.g. .service files should be read only not executable)

I hope you find this usefil and will accept my edits

hirak99 commented 1 year ago

Thank you!

I had a single script so that it can be used for different OS'es.

But I understand your suggestion follows Arch guidelines. I think it may then make sense to use it and mantain a separate script for other OS.

If you allow me some time, let me investigate it, and integrate it - hopefully by this weekend.

On Wed, Oct 25, 2023, 21:45 nebulosa2007 @.***> wrote:

I have updated PKGBUILD using this article https://wiki.archlinux.org/title/Arch_package_guidelines.

New PKGBUILD https://0x0.st/Hyrj.txt and the install file https://0x0.st/Hyre.txt.

Why? Because, it's not quite right to build package through bash script - it cause errors in future like #17 https://github.com/hirak99/yabsnap/issues/17 and other mistakes with permission of files (e.g. .service files should be read only not executable)

I hope you find this usefil and will accept my edits

— Reply to this email directly, view it on GitHub https://github.com/hirak99/yabsnap/issues/18, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN3FYUCN4UU3RNXE7U4GS3YBE3JDAVCNFSM6AAAAAA6PUZPYWVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DCNZYGUYTGNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hirak99 commented 1 year ago

I don't think I could have written anything as good.

Not only did you just change it for the guidelines, you also corrected some more issues and removed the rsync dependency.

You have my heartfelt thanks!

Pushed with some minor changes, hope I didn't mess anything up.

nebulosa2007 commented 1 year ago

Just one more point.

In my PKGBUILD I also renamed hook file from 05... to 01... . My logic is: making a snapshot should have a highest priority and must execute before than others pacman hooks. Am I right?

hirak99 commented 1 year ago

Yeah that makes sense.

TBH it was the reason I chose 05 which is seemed pretty low - and to keep it open in case other utilities need to go lower.

But honestly I cannot think of anything else that may need a higher priority; and we run the risk of erroneously letting a different utility make changes before the snapshot is run.

So 01 seems objectively better. Can always revert if this conflicts with something.

Made the change now in this repo 7f3c0dfe4143dd3cce4e212d8f713129dc6359d1 and PKGBUILD.