search

hirakiuc / tinybucket

A Ruby client library for Bitbucket REST API v2 with OAuth Authentication.
MIT License
33 stars 36 forks source link

Implemented Tags API based on the current Branches API #144

Closed VitorHP closed 1 year ago

VitorHP commented 5 years ago

So. I needed the Tags API to work for a pet project of mine, so I did it basically copying all the Branch related stuff and renaming appropriately fixing stuff when necessary.

Dont't know if that's the way you would approach that. Maybe generalizing an Entity that could be used for both tags and branches would be better since they work pretty much the same way.

hirakiuc commented 5 years ago

Sorry, I found this just now.

Thanks for your contribution 👍

Don't know if that's the way you would approach that. Maybe generalizing an Entity that could be used for both tags and branches would be better since they work pretty much the same way.

hmm.

Bitbucket has so many resources. There are some resources which they look like almost the same. So tinybucket may be refactored/re-designed to define those resource by using inheritance 🤔

But I already don't use Bitbucket and don't have enough time to do that, sorry 😭

Anyway, Creating a new Model looks good for me, just now 👍

hirakiuc commented 5 years ago

I'll check this tomorrow in detail 🙋‍♂️

jackwilliams04 commented 2 years ago

Can this be merged if all is ok? I would love to be able to use this new tag method for calling the BB api :) I appreciate that it has been a few years since the last update though!

hirakiuc commented 1 year ago

I'll merge this PR for now even though I have no test environment, without actual E2E test. (I'll add some E2E test case in CI, later. 🙋🏼)

Sorry for this long delay, thanks for your patient.