hiramvillarreal
commented
5 years ago I've removed the card number and auth number. Storing credit card details in this manor I'm sure is not safe? It is just for reference you should keep the printed voucher it is juts to identified what printed voucher was used to paid what transaction please do not remove. Integrating it would be the next major change but lack of access to this machine make it hard for us to code it
Yes that will be the next as option but since then we need to keep those fields.
The changes now will bring up a message box asking if the EFTPOS machine approved the transaction. If yes is pressed then the sale will go though. If no is selected the the current transaction is cancelled. I did try to make it go back to the sale screen but was unable to find it. When we had knowledge how the EFTPOS works probably we will find it gives the auth number to be filled automatically by the terminal.
We could add to configuration whet the EFTPOS machine is available that could make the field read only for cashier and a manual setting when there not the EFTPOS machine avalible
De: Shane Rees [mailto:notifications@github.com] Enviado el: martes, 29 de enero de 2019 07:36 a. m. Para: hiramvillarreal/iotpos CC: Hiram Villarreal; Mention Asunto: [hiramvillarreal/iotpos] Changes to the credit card operation (#26)
I've removed the card number and auth number. Storing credit card details in this manor I'm sure is not safe?
This also opens this up for the use of a manual EFTPOS machine. Some of these machines allow the operator to enter the amounts manually as apposed to integrating it.
Integrating it would be the next major change but lack of access to this machine make it hard for us to code it.
The changes now will bring up a message box asking if the EFTPOS machine approved the transaction. If yes is pressed then the sale will go though. If no is selected the the current transaction is cancelled. I did try to make it go back to the sale screen but was unable to find it.
I also added myself as a contributor as I've now made quite a few changes. Also updated the copyright to update from 2015 to 2019 (I'm sure this was a slight oversight)
As normal @hiramvillarrealhttps://github.com/hiramvillarreal its for you to approve
You can view, comment on, or merge this pull request online at:
https://github.com/hiramvillarreal/iotpos/pull/26
Commit Summary
- add crdit card changes
File Changes
- M src/iotposview.cpphttps://github.com/hiramvillarreal/iotpos/pull/26/files#diff-0 (71)
- M src/ui/mainview.uihttps://github.com/hiramvillarreal/iotpos/pull/26/files#diff-1 (61)
Patch Links:
- https://github.com/hiramvillarreal/iotpos/pull/26.patch
- https://github.com/hiramvillarreal/iotpos/pull/26.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/hiramvillarreal/iotpos/pull/26, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKFJWEFCw5X35_uXzDW-94-pqaWM1A56ks5vIFxCgaJpZM4aYLbI.
I've removed the card number and auth number. Storing credit card details in this manor I'm sure is not safe?
This also opens this up for the use of a manual EFTPOS machine. Some of these machines allow the operator to enter the amounts manually as apposed to integrating it.
Integrating it would be the next major change but lack of access to this machine make it hard for us to code it.
The changes now will bring up a message box asking if the EFTPOS machine approved the transaction. If yes is pressed then the sale will go though. If no is selected the the current transaction is cancelled. I did try to make it go back to the sale screen but was unable to find it.
I also added myself as a contributor as I've now made quite a few changes. Also updated the copyright to update from 2015 to 2019 (I'm sure this was a slight oversight)
As normal @hiramvillarreal its for you to approve