search

hirbod / react-native-volume-manager

React Native module which adds the ability to change the system volume on iOS and Android, listen to volume changes and supress the native volume UI to build your own volume slider or UX. It can listen to iOS mute switch and ringer mode changes on Android (and let you set the ringer mode)
MIT License
216 stars 14 forks source link

Upgrade kotlin version for react-native-volume-manager to support kotlin-android-extensions plugin 1.6.20 #11

Closed MartsTech closed 1 year ago

MartsTech commented 1 year ago

Description

The Android Gradle plugin requires kotlin-android-extensions Gradle plugin version 1.6.20 or higher. However, the current version of the react-native-volume-manager dependency is using org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10, which does not satisfy the required version. As a result, building the project fails with the following error message:

The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher. The following dependencies do not satisfy the required version: project ':react-native-volume-manager' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10.

Solution:

To resolve this issue, we need to upgrade the kotlin version to 1.6.20 or higher in the react-native-volume-manager dependency. This can be achieved by updating the version number of the kotlin-gradle-plugin in the build.gradle file of the react-native-volume-manager module to 1.6.20 or higher.

hirbod commented 1 year ago

Thanks for raising this. I'll take care this weekend. This will most likely target RN 0.71+ only though, so I'll make a breaking change release.

MartsTech commented 1 year ago

Hi @hirbod, just checking in to see if there has been any progress on upgrading the kotlin version for react-native-volume-manager. Thank you for looking into this issue!

hirbod commented 1 year ago

Sorry @MartsTech I was caught up and will be back after easter. Will tackle this after.

hirbod commented 1 year ago

Hi @MartsTech, I started working on it. Expect a release soon!

pratik-yadav-cvent commented 1 year ago

Hi @hirbod, Is there any ETA for this fix?

hirbod commented 1 year ago

New release is ready in ~1 hour

hirbod commented 1 year ago

Version 1.3.0 has been released. This issue is resolved now.