search

hirmeos / altmetrics

Implementation of HIRMEOS WP6
MIT License
5 stars 0 forks source link

Bug Fix: Wikipedia client crashes when fetching some pages #32

Closed rowan08 closed 5 years ago

rowan08 commented 5 years ago

When the wikipedia Python package tries to fetch a page, there is logic that prioritizes suggestions over actual results, which causes the client to crash if the suggestion is wrong. So we just need to update the client calls to work around this.

On a related note, the wikipedia Python package we use (https://pypi.org/project/wikipedia/) is fairly outdated - it hasn't been updated since 2014. I have not yet been able to find a suitable replacement, but it may be worth looking into.

rowan08 commented 5 years ago

Update: There are some Wikipedia events returned by Crossref Event Data, which aren't 'wikipedia' pages, but are still 'wikimedia' links, e.g. commons.wikimedia.org, wikisource.org, meta.wikimedia.org, etc.

The wikipedia Python client we are using is not designed to handle these types of pages. Fortunately, the wikimedia API makes it fairly easy to find the external links for these pages, so additional logic can be added to handle them.