search

hirodaisohaken / website

1 stars 0 forks source link

some changes: config.toml, access/, members/, i18n/ and sohakenTheme #20

Closed biyori-sh closed 2 years ago

biyori-sh commented 2 years ago

I set baseURL for both languages for the link in the header working. When we do hugo server, the url of HOME in English version is modified as localhost:1314/, not localhost:1313/en/. And I deleted [markup.goldmark.renderer] by using shortcodes/ in config.toml. I tried to change access/_index -> access/_access and members/_index -> members/_members so that list.html is not applied.

In sohakenTheme I improved README.md (now only Japanese). I changes .Description -> .Title in some html files, background-color of the sidebar, and settings for links in the css file. For Google Maps, I created shortcodes/google-maps.html. And for opening links in a new tab, _default/_markup/render-link.html was created.

redeagletwo commented 2 years ago

Thank you for the changes. The access and member pages are greatly improved. Also the README.md is great!

So, I think it is better to have different urls for Japanese and English versions. Maybe there is a different way to fix the header.

biyori-sh commented 2 years ago

Thank you for the improvements.

Could you Merge pull request if there is no problem?

biyori-sh commented 2 years ago

I have already included many things in the one commit, but I am sorry for this myself. I feel that it is not good to include too many things that is little to do with each other into one pull requast.