hirodaisohaken / website

1 stars 0 forks source link

sub-sh0.6.1 (after Pull request #20): modify how to list articles and structure of directories #22

Closed biyori-sh closed 2 years ago

biyori-sh commented 2 years ago

After Pull request https://github.com/HirodaiSoken/website/pull/20

I modified config.toml and created /sohakenTheme/layouts/section/. So _index.xx.md is available at access/ and members/ without list.html. To avoid introducing the new front matter, news, I modified how to list the articles (related to https://github.com/HirodaiSoken/website/pull/20#discussion_r874517612). For example, {{ if .Params.news }} -> {{ if or (eq .Section "seminars") (eq .Section "news") }} in layouts/index.html.

is commented out as HTML codes, but not commended out as Hugo codes. To comment out Hugo codes, we have to use {{/* */}}. I modified the structure of directories with deleting events/ based on the previous meeting (05/10).
biyori-sh commented 2 years ago

Some of the markdown files still have the params news. The homepage HTML file themes/sohakenTheme/layouts/index.html no longer uses this. So, I believe all the markdown files should have the header information news removed.

Sorry if I make a wrong guess. It is a bit unclear to me; did you point out {{ if or (eq .Section "seminars") (eq .Section "news") }} in themes/sohakenTheme/layouts/index.html? If so, it is not needed to remove because the "news" indicates the name of the directory in content/ (called Section in Hugo), not the pamater that is introduced as the front matter.

I have already asked you about the structure by email at 05/14, and do not receive its corrections. So I align the directory tree based on the discussion that is done at 05/10 as I recall it. In this discussion, wasn't it said that events/ and news/ are the same? Could you create the directory tree in content/ based on the discussion 05/10 and commit it? Related to the issues https://github.com/HirodaiSoken/website/issues/7 and https://github.com/HirodaiSoken/website/issues/9.

Also, if we are deleting events/ I think we should delete all of the old website folders too.

If you think that, it's ok to delete them. Because they are not active now, it is not a priority to delete them for me.

redeagletwo commented 2 years ago

The structure is great! No problems there. The change to the HTML file {{ if or (eq .Section "seminars") (eq .Section "news") }} in themes/sohakenTheme/layouts/index.html is clear to me and I think it is better than the previous implimentation. What I mean is in the header of the .md files for example content/access/_index.en.md still holds the previous implimentation of news: false. I have done a new commit to fix all of those files of,

Sorry for the confusion.