search

hirodaisohaken / website

1 stars 0 forks source link

Name of graduate school in English footer is incorrect #27

Closed redeagletwo closed 2 years ago

redeagletwo commented 2 years ago

In addition, the official name (new name) for our graduate school is Graduate School of Advanced Science and Engineering. Please check this website: https://www.hiroshima-u.ac.jp/en/adse/about. We should revise the website footer (English web version).

Originally posted by @ahariwangsa in https://github.com/HirodaiSoken/website/issues/13#issuecomment-1191314519

This requires a change to the english i18n file.

redeagletwo commented 2 years ago

Fixed in #29.

I also found a bug with the definition of other = "(Since 2009.8.17)" in i18n/en.toml where the title was incorrect. I changed [since] to [footer-since] to fix the issue and match the themes partials/footer.html definition. No issues were found with the Japanese version.