search

hirohe / tweakpane-plugin-search-list

plugin for tweakpane, searchable select list
MIT License
7 stars 0 forks source link

Strict peer dependencies #1

Closed hexus closed 3 years ago

hexus commented 3 years ago

Hi there!

I'm interested in taking this Tweakpane plugin for a spin, but the strict peer dependencies would force me to use npm update --force or npm update --legacy-peer-deps in order to do so, because you've listed very specific versions for Lodash and Tweakpane as the library's peer dependencies.

I was hoping these could be loosened up with a caret:

  "peerDependencies": {
    "lodash": "^4.17.21",
    "tweakpane": "^2.3.0"
  },

I expect semver well prevent any breakages here.

Cheers!

hirohe commented 3 years ago

thanks for report this problem, it is mistack to set a specific version in peerDependencies

hirohe commented 3 years ago

tweakpane 2.2.0 above has huge refactoring, it will break this plugin

i have to do some change too

hexus commented 3 years ago

Ah, indeed. Perhaps Tweakpane isn't following semantic versioning so closely if the plugin breaks, then.

Either way, thank you for loosening the dependencies as you have! I'll keep an eye out for an updated version that works with 2.3/3.x.

cocopon commented 3 years ago

At this point, semver of Tweakpane is working correctly for users, but not for plugin developers. I may need to separate its core as another package. I plan to fix it after releasing the next major version, sorry for the inconvenience...!

hexus commented 3 years ago

No worries at all, thanks for such a swift response and taking it into account! 🙏