search

hirokawa / cssrlib

Python Toolkit for satellite-based open PPP/PPP-RTK services
MIT License
117 stars 37 forks source link

Error Occurs When Decoding Galileo-HAS and Outputting as File #48

Open opgn716 opened 6 months ago

opgn716 commented 6 months ago

Dear Dr. Rui Hirokawa,

Thanks for providing the compact PPP/PPP-RTK toolkit. I can really learned a lot following your tutorial.

However, I found one issue when decoding Galileo-HAS and output the result as a file. In the "self.outlog()" function of "cssrlib.py", when "self.subtype == sCSSR.CBIAS", you get the keys like this: for sig in range(self.lc[0].pbias[sat_].keys()): However, the "range()" function doesn't seem to support arguments of type 'dict_keys'. The similar issue also arises when 'subtype == sCSSR.PBIAS'. In my attempt, removing the “range()” function allows the program to run normally. If I have misunderstood, I humbly request correction.

Best regards

hirokawa commented 6 months ago

Thank you for finding a bug in out_log(). out_log() is still based on the old sig structure, it needs to be updated. The code in devel branch is already fixed, it will be merged into master branch soon. Rui

opgn716 commented 2 weeks ago

Dear Dr. Rui Hirokawa, I am experiencing a problem with the calculation of orbit corrections. Why is it necessary to multiply by -1 after completing the computation? 59e9b4189000e87b32dabf19291196c

hirokawa commented 2 weeks ago

It is because the sign convention of orbit correction for Galileo HAS SIS is opposite from the standard one such as RTCM SSR. cssrlib is based on the standard convention. For the detail, please check our ION GNSS+ 2023 paper.

opgn716 commented 2 weeks ago

Got it. Thanks for your patience!