hiroppy / fusuma

✍️ Fusuma makes slides with Markdown easily.
https://hiroppy.github.io/fusuma
5.41k stars 194 forks source link

Making webpack plugins addable #152

Closed yamatatsu closed 5 years ago

yamatatsu commented 5 years ago

Would you have plans to make webpack config extendable or webpack plugin addable? Or, does it not match fusuma's policy "zero config" ?

Type

What is the motivation or use-case for the feature?

I wanna add plugins for using monaco-editor on fusuma. https://github.com/microsoft/monaco-editor-webpack-plugin

Thanks!

hiroppy commented 5 years ago

Nope, I'll implement extending webpack.config.js feature.

hiroppy commented 5 years ago

@yamatatsu Which one do you like either cli(--webpack ?) or .fusumarc? I think .fusumarc is better because you can omit CLI flag every time. And we have already had extends field in .fusumarc.

Sorry, I implemented this feature, but I wait to welcome feedback.

yamatatsu commented 5 years ago

Great!! So fast!! Thanks!!

I think .fusumarc is better, too. Because there is original config system .fusumarc already. I think it is good that one config-file maps whole configurations.

hiroppy commented 5 years ago

OK, thanks. I'll release this feature shortly!

hiroppy commented 5 years ago

I've just released this feature. thanks. https://github.com/hiroppy/fusuma/releases/tag/v1.13.0