search

hiroprotagonist / jquery.mobile.actionsheet

An actionsheet for jquerymobile
103 stars 34 forks source link

Multiple wallpaper created while open/close multiple time #6

Closed TanvirM closed 13 years ago

TanvirM commented 13 years ago

JQM version: 1.0b1

Issue: After open and close first time, on the second time the box is not closed properly.

Reason: In the open function the wallpaper DIV append with jqm-content. This append content stored in the hash history, after hit the close button second time the immediate wallpaper div removed but the one from history stays on.

Solve: Create the wallpaper at initiation and keep it hidden [Check the changes on my fork.]

hiroprotagonist commented 13 years ago

Hey Tanvir

Its hard to find your changes since your editor changed every tab into 4 whitespaces on every line. I know that almost everybody use spaces instead of tabs. crazy world. please tell me wich lines you changed.

hiroprotagonist commented 13 years ago

Again... I cannot reproduce your issue. I am opening and closing the sheet several times. The DOM still gets cleaned up and the wallpaper gets removed. Can you please post your test markup.

Regards Stean

TanvirM commented 13 years ago

Sorry about that, I'm a bit of old school, steel use notepad++, anyway

on this file https://github.com/TanvirM/jquery.mobile.actionsheet/blob/de22c1bdd469679b3c82c7b12a89caf1ad660f0b/jquery.mobile.actionsheet.js

look for following lines

Line 31 - 37 Line 61 - 66 Line 70, 89, 100, 109

TanvirM commented 13 years ago

This might help...

T

On Thu, Jun 30, 2011 at 8:27 PM, hiroprotagonist < reply@reply.github.com>wrote:

Again... I cannot reproduce your issue. I am opening and closing the sheet several times. The DOM still gets cleaned up and the wallpaper gets removed. Can you please post your test markup.

Regards Stean

Reply to this email directly or view it on GitHub:

https://github.com/hiroprotagonist/jquery.mobile.actionsheet/issues/6#issuecomment-1475162

Tanvir M. Shuvo

hiroprotagonist commented 13 years ago

Ahoi Tanvir! Im sorry but i cannot reproduce the behavior. I am closing this issue and i hope that you still enjoy working with actionsheet.

Cheers Stefan

TanvirM commented 13 years ago

Hi Stefan,

Sure you can close the issue... it's probably because of my complex integration. Thanks again for your work on actionsheet.

Cheers

On 7/22/2011 2:35 AM, hiroprotagonist wrote:

Ahoi Tanvir! Im sorry but i cannot reproduce the behavior. I am closing this issue and i hope that you still enjoy working with actionsheet.

Cheers Stefan

Tanvir M. Shuvo +880 167 1675652