search

hirosassa / terraform-provider-looker

Terraform Provider for managing Looker
https://registry.terraform.io/providers/hirosassa/looker/latest
MIT License
20 stars 13 forks source link

fix typo on line 373 of resource_connection.go #48

Closed jbennett7 closed 1 year ago

jbennett7 commented 1 year ago

Fix typo https://github.com/hirosassa/terraform-provider-looker/blob/89a1ec42026600176be2843b77727b352030e327/pkg/looker/resource_connection.go#L373

hirosassa commented 1 year ago

hmmm, lint is failed. I'll take a closer look.

jbennett7 commented 1 year ago

There is another typo on Line 176 of the same file when using pdt_context_override block: https://github.com/hirosassa/terraform-provider-looker/blob/89a1ec42026600176be2843b77727b352030e327/pkg/looker/resource_connection.go#L176

Should I add the fix to that to this PR?

hirosassa commented 1 year ago

@jbennett7 Thanks! Let's fix it in this PR too.

jbennett7 commented 1 year ago

done

jbennett7 commented 1 year ago

Fixed typo in the documentation as well: docs/resources/connection.md

jbennett7 commented 1 year ago

Hello,

I appreciate the feedback for this. Is there anything else that needs to be completed for this? Do we have a timeline for when these fixes can be implemented?

hirosassa commented 1 year ago

@jbennett7 Sorry for massively late reply. I fixed CI in https://github.com/hirosassa/terraform-provider-looker/pull/50. Cloud you please rebase current master? I'll merge this PR after rebase.

hirosassa commented 1 year ago

Looks good! I'll merge this. @jbennett7 Thanks for your contribution and patience.

hirosassa commented 1 year ago

@jbennett7 Thanks again! I released new version of this provider. https://github.com/hirosassa/terraform-provider-looker/releases/tag/v0.9.0