search

hiroshinishio / julia

The Julia Programming Language
https://julialang.org/
MIT License
0 stars 0 forks source link

GitAuto: Core.println repr wrong for Core.IntrinsicFunction type #16

Closed gitauto-for-dev[bot] closed 3 months ago

gitauto-for-dev[bot] commented 3 months ago

Original issue: #9

Why the bug occurs

The bug occurs because the jl_static_show function in rtutils.c is not correctly handling the special case of Core.IntrinsicFunction types. The Symbol name in the MethodTable of jl_intrinsic_type is causing confusion, leading to incorrect representation when printed.

How to reproduce

  1. Call which(Core.Compiler.is_pure_intrinsic_infer, (Core.IntrinsicFunction,)).sig and observe the correct output.
  2. Pipe the result to Core.println and observe the incorrect representation.
  3. Check the name and method table name of Core.IntrinsicFunction to see the inconsistency.

How to fix

  1. Modify the jl_static_show function in rtutils.c to utilize the jl_intrinsic_name function for Core.IntrinsicFunction types. This will ensure that the correct identifier is printed.
  2. Update the is_globname_binding function to take an additional argument indicating whether v is a value or type. This will allow branching based on this information instead of using the || operator, which currently leads to incorrect behavior.
  3. Test the changes to ensure that the representation is now consistent and correct for Core.IntrinsicFunction types. """

Test these changes locally

git checkout -b gitauto-wes/issue-#9-4ecd4efc-9247-4641-9dc5-4ed01d5471de
git pull origin gitauto-wes/issue-#9-4ecd4efc-9247-4641-9dc5-4ed01d5471de