Generalize joinpath to take the OS as an argument

[vtjnash]

I'd love if we merged the lines https://github.com/JuliaLang/julia/blob/6f3fdf7b36250fb95f512a2b927ad2518c07d2b5/base/path.jl#L257-L325 which currently contain two different joinpath functions based on your OS, into a single function which gets an os-keyword. Concept idea:

function joinpath(parts; os=Sys.KERNEL)
  if Sys.iswindows(os)
    #windows variant of joinpath
  else
    #other variant of joinpath
  end
end

joinpath(parts...; os=Sys.KERNEL) = joinpath(parts; os)

Many of the other functions (such as splitdir and the path regexes) may need to be similarly generalized to allow the user to call both the Windows and Unix variants of those

From https://github.com/JuliaLang/julia/issues/55648

[gitauto-ai[bot]]

Click the checkbox below to generate a PR!

• [x] Generate PR

@vtjnash, You have 5 requests left in this cycle which refreshes on 2024-09-04 02:56:25+00:00. If you have any questions or concerns, please contact us at info@gitauto.ai.

[gitauto-ai[bot]]

Sorry, we have an error. Please try again.

Have feedback or need help? Feel free to email info@gitauto.ai.

[rapus95]

Many of the other functions (such as splitdir and the path regexes) may need to be similarly generalized to allow the user to call both the Windows and Unix variants of those

@vtjnash I wonder if it makes sense to create modules for the OS and group all the functions according to OS and then only create a new layer of functions which redirects into the right OS module (which holds different FUNCTION objects than the outer redirectors). That way each call would use compatible splitdir, regexes etc since the OS arg just decides on the entry point for the machinery.

[vtjnash]

That is possible, and I was considering that too, though dispatch is more common. With this, I was hoping to discover what sort of implementation gitauto would come up with, and how close it would come to the proposed design. It seems there was an unexplained failure though?

[gitauto-ai[bot]]

Sorry, we have an error. Please try again.

Have feedback or need help? Feel free to email info@gitauto.ai.