hiroshinishio / julia

The Julia Programming Language
https://julialang.org/
MIT License
0 stars 0 forks source link

Core.println repr wrong for Core.IntrinsicFunction type #9

Open vtjnash opened 3 months ago

vtjnash commented 3 months ago
julia> which(Core.Compiler.is_pure_intrinsic_infer, (Core.IntrinsicFunction,)).sig
Tuple{typeof(Core.Compiler.is_pure_intrinsic_infer), Core.IntrinsicFunction} # good

julia> which(Core.Compiler.is_pure_intrinsic_infer, (Core.IntrinsicFunction,)).sig |> Core.println
Tuple{typeof(Core.Compiler.is_pure_intrinsic_infer), typeof(Core.IntrinsicFunction)} # bad

julia> Core.IntrinsicFunction.name
typename(Core.IntrinsicFunction) # good

julia> Core.IntrinsicFunction.name.name
:IntrinsicFunction # good

julia> Core.IntrinsicFunction.name.mt.name
:IntrinsicFunction # bad

The Symbol name in the MethodTable of jl_intrinsic_type is causing jl_static_show to become confused. However, this is also a special case value where we know the names of each of them in Core.Intrinsics by calling the jl_intrinsic_name function. The jl_intrinsic_name function can be used in jl_static_show in rtutils.c to print the correct identifier here.

Secondly is_globname_binding should take an extra argument of whether v is the value or type, and branch accordingly instead of trying to be clever with || in that comment there.

gitauto-ai[bot] commented 3 months ago

Welcome to GitAuto! πŸŽ‰ Click the checkbox below to generate a PR!

You have 5 requests left in this cycle which refreshes on 2024-09-04 02:56:25. If you have any questions or concerns, please contact us at info@gitauto.ai.

gitauto-for-dev[bot] commented 3 months ago

@vtjnash @hiroshinishio Pull request completed! Check it out here https://github.com/hiroshinishio/julia/pull/10 πŸš€ Should you have any questions or wish to change settings or limits, please feel free to contact info@gitauto.ai or invite us to Slack Connect.

gitauto-ai[bot] commented 3 months ago

@vtjnash @hiroshinishio Pull request completed! Check it out here https://github.com/hiroshinishio/julia/pull/11 πŸš€ Should you have any questions or wish to change settings or limits, please feel free to contact info@gitauto.ai or invite us to Slack Connect.

gitauto-for-dev[bot] commented 3 months ago

@vtjnash @hiroshinishio Pull request completed! Check it out here https://github.com/hiroshinishio/julia/pull/14 πŸš€ Should you have any questions or wish to change settings or limits, please feel free to contact info@gitauto.ai or invite us to Slack Connect.

gitauto-for-dev[bot] commented 3 months ago

@vtjnash @hiroshinishio Pull request completed! Check it out here https://github.com/hiroshinishio/julia/pull/15 πŸš€ Should you have any questions or wish to change settings or limits, please feel free to contact info@gitauto.ai or invite us to Slack Connect.

gitauto-for-dev[bot] commented 3 months ago

@vtjnash @hiroshinishio Pull request completed! Check it out here https://github.com/hiroshinishio/julia/pull/19 πŸš€ Should you have any questions or wish to change settings or limits, please feel free to contact info@gitauto.ai or invite us to Slack Connect.

gitauto-ai[bot] commented 2 months ago

Sorry, we have an error. Please try again.

Have feedback or need help? Feel free to email info@gitauto.ai.