hirosystems / btc-us-website

50 stars 15 forks source link

incorrect messaging on step 2 register #1

Open alexrudloff opened 3 years ago

alexrudloff commented 3 years ago

When you first submit a registration request, it tells you something went wrong but says pending next to the transaction id.

image

After a few seconds, it self corrects

image

314159265359879 commented 3 years ago

this happens because there is some time where the transaction is somewhere between the btc.us server and the blockchain. I have seen this two three times while testing myself.

I have had one instance where the message did not go away and all you could do is press the "start over" button. Marvin thought this was due to an API server that is stressed. The problem is in that case the preorder did go through.

If you preorder again the transaction will fail and the order transaction will never be send. I think the site should check if the account has a preorder confirmed less then 144 burnchain blocks ago when the "start over" button is pressed so an account can choose to only resend the "register" transaction.

Some screenshots and transaction id's (Chrome/Windows & Alexander.btc reported the same on Chrome/macOS). First time preorder: https://explorer.stacks.co/txid/0x1a0f16e29c436abf7980fb263254e3058b77cb28800de2449e255baacdb23f4a?chain=mainnet image Waited for confirmation before proceeding with register.

This is the transaction link that was made but never got to the blockchain: https://stacks-node-api.blockstack.org/extended/v1/search/ffbc010ec64b650c14ddfac969002a9dd9d04c251ddac0dc7864d990d41d7b29 all you get is image

314159265359879 commented 3 years ago

Second preorder and register send at once. Stays on the loading screen. I would expect the preorder to fail but the register to go through but I guess the hash may be different on this preorder so this can never work with the preorder that I got confirmed before "start over".

Stuck on loading

image

Preorder still in the mempool after a day.

image

Transfer for register never got through 404

image

314159265359879 commented 3 years ago

The preorder expired and it kept showing the loading screen.

I had to wait until the garbage collector threw the second preorder out of the mempool. image

Start over button appeared

Trying again to register yields this (new!) error: image

The BNS name was already registered by another account, also shown by the API is-name-available.