Fix and improve chainhook client types - Githubissues

hirosystems / chainhook

Extract transactions from Stacks and Bitcoin and build event driven re-org resistant indexers and databases.

GNU General Public License v3.0

158 stars 65 forks source link

Fix and improve chainhook client types #314

Closed BLuEScioN closed 1 year ago

BLuEScioN commented 1 year ago

Fix incorrect types

[ ] p2pkh
[ ] p2sh
[ ] p2wpkh
[ ] p2wsh
[ ] leader_registered instead of leader_key_registered

Break types up to make them more consumable

[ ] Break up predicates into BitcoinIfThis and StacksIfThis
[ ] BitcoinScopes and StacksScopes
[ ] IfThat type
[ ] AdditionalConfig and BitcoinAdditionalConfig and StacksAdditionalConfig

If you look at chainhook-types and chainhook-config here, you can get a good idea of how I am consuming my own chainhook types on the client side

rafaelcr commented 1 year ago

@BLuEScioN I think some of the types you mention are already broken up, like here: https://github.com/hirosystems/chainhook/blob/develop/components/client/typescript/src/schemas/stacks/if_this.ts

Are you able to import them? Each of those has its own exported type