search

hirosystems / clarinet

Write, test and deploy high-quality smart contracts to the Stacks blockchain and Bitcoin.
https://hiro.so/clarinet
GNU General Public License v3.0
290 stars 129 forks source link

ci: fix homebrew release #1420

Closed hugocaillard closed 2 months ago

hugocaillard commented 2 months ago

Description

The release actions failed on the homebrew step for clarinet 2.5.0: https://github.com/hirosystems/clarinet/actions/runs/8690598712 With the error:

Invalid usage: clarinet: no `--url` or `--version` argument specified!

I was able to open the homebrew PR by running this command locally:

brew bump-formula-pr \
  --no-browse \
  --no-audit \
  --force \
  --tag 22e10c2f004ebdc3d07cd475844eaa4d11ebbb75 \
  --version 2.5.0 \
  clarinet

Looks like there was a breaking change in the bump-formula-pr command

hugocaillard commented 2 months ago

Thanks @CharlieC3 I knew a copy/paste wouldn't be enough.

That part is good right? --version ${VERSION} \ (we don't need quotes "--version "${VERSION}" \?)

CharlieC3 commented 2 months ago

That part is good right? --version ${VERSION} \ (we don't need quotes "--version "${VERSION}" \?)

Hmm may be best to add the quotes to match the other arg just in case.

hugocaillard commented 2 months ago

Alright, done @CharlieC3 Thx!

hugocaillard commented 2 months ago

thx @CharlieC3