search

hirosystems / clarinet

Write, test and deploy high-quality smart contracts to the Stacks blockchain and Bitcoin.
https://hiro.so/clarinet
GNU General Public License v3.0
305 stars 139 forks source link

Include 'x-hiro-product' in HTTP header #994

Open sabbyanandan opened 1 year ago

sabbyanandan commented 1 year ago

Context in slack here.

Let's ensure the deployment plans, requirements, and new project code paths include an additional header k/v pair (i.e., 'x-hiro-product':'clarinet').

hugocaillard commented 1 year ago

@sabbyanandan Is it something we want to see happening in Q4? If so, it wouldn't be part of v2.0 but could be 2.1

sabbyanandan commented 1 year ago

@hugocaillard: Sooner the better, please. I would even consider doing it in v1.x and onwards.

hugocaillard commented 1 year ago

@sabbyanandan There won't be any other v1.x releases. And I think that v2.0 shouldn't be delayed anymore. But a 2.1 could follow pretty soon after

sabbyanandan commented 1 year ago

There won't be any other v1.x releases.

Assuming we will consider supporting older stable releases until 2.x becomes mainstream. I am just thinking out loud for the end users to ensure they aren't able to upgrade for any reason, and that we may have to backport bug-fixes to help them out.

And I think that v2.0 shouldn't be delayed anymore.

What is the driver for this urgency?

hugocaillard commented 1 year ago

Assuming we will consider supporting older stable releases until 2.x becomes mainstream. I am just thinking out loud for the end users to ensure they aren't able to upgrade for any reason, and that we may have to backport bug-fixes to help them out.

Clarinet v1.x does not build on Homebrew, hence the work on 2.0, so we expect 2.x to become mainstream asap.

Maintaining two streams of Clarinet versions (1.x that wouldn't be released of homebrew and 2.x that would be released everywhere) seems like a big effort and we probably don't have the bandwidth for that.

What is the driver for this urgency?

It's not really an urgency. It's part of the release plan of the SDK + Clarinet 2.

All of the new projects and contracts that are being generated with Clarinet 1 still assume that tests will be run with clarinet test / Deno. So we want Clarinet 2 to be released to end the deprecation of the Deno stuff.

If there is any urgency, it's to release Clarinet 2 and start working on the clarity-to-wasm integration, since everything related to Nakamato takes the priority over other Clarinet tasks

sabbyanandan commented 1 year ago

since everything related to Nakamato takes the priority over other Clarinet tasks

@hugocaillard: Understood, thanks.