search

hirosystems / connect

A library for building excellent user experiences with Stacks.
https://connect.stacks.js.org
MIT License
76 stars 40 forks source link

Feat: show xverse as desktop option #295

Closed m-aboelenein closed 1 year ago

m-aboelenein commented 1 year ago

Description

The current UI only shows Xverse as an option for mobile wallet. With the release of Xverse web extension, the UI should be updated to show xverse as an option for chrome wallet as well. The UI is updated to add Xverse in the wallet options to connect with.

Type of Change

Does this introduce a breaking change?

No

Are documentation updates required?

No

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 48a6f3382dfe57efefc6ac5aae0862c962875484

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
connect-docs ✅ Ready (Inspect) Visit Preview Dec 28, 2022 at 4:01PM (UTC)
janniks commented 1 year ago

Thanks, 🙏 there some minor things CI is complaining about. I can fix these if you want (I'll need access to this PR though)

m-aboelenein commented 1 year ago

Thanks, 🙏 there some minor things CI is complaining about. I can fix these if you want (I'll need access to this PR though)

Hey @janniks! i wasn't able to give you access to the pr since the fork is owned by our org and not my personal account, is it just the commit message syntax? or do i need to do something else ?

👍 For now I think this is good enough and the somewhat obvious path.

I'll add a task to refactor this, to scale better when more wallet/apps are added

we are very happy to help with that when you decide on implementing it

janniks commented 1 year ago

Merged via #301