hirosystems / connect

A library for building excellent user experiences with Stacks.
https://connect.stacks.js.org
MIT License
77 stars 40 forks source link

refactor: sighash types to match btckit api #332

Closed fbwoolf closed 1 year ago

fbwoolf commented 1 year ago

This PR was published to npm with the alpha versions:

  • connect npm install @stacks/connect@7.3.2-alpha.455575e.0 --save-exact
  • connect-react npm install @stacks/connect-react@22.1.2-alpha.455575e.0 --save-exact
  • connect-ui npm install @stacks/connect-ui@6.1.2-alpha.455575e.0 --save-exact

This PR refactors the signPsbt api allowedSighash types to be inclusive of all possible.

Ref changes in btckit: refactor/sighash-types

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 455575e837b1fbcab5bf9d37242bed54d6a48ef7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | --------------------- | ----- | | @stacks/connect | Patch | | @stacks/connect-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 5:19pm
fbwoolf commented 1 year ago

Any reason not to just import & export from btckit Fara?

Not really, I can close this? Was just trying to provide parity for apps using this api.

janniks commented 1 year ago

Not sure I follow, should we close?