search

hirosystems / connect

A library for building excellent user experiences with Stacks.
https://connect.stacks.js.org
MIT License
77 stars 40 forks source link

Add persisted version of `showConnect` #369

Open janniks opened 9 months ago

janniks commented 9 months ago

Right now showConnect doesn't persist selection (for backwards comp)

But users might want this, so we should have a showConnectPersist, which stores the provider id.

This could be changed to a breaking change to always persist showConnect later.

kyranjamie commented 9 months ago

This would be a great addition, especially as we move away from shared namespaces.

markmhendrickson commented 9 months ago

Might it even be better to have showConnect be the persisted version, since presumably this is what developers expect / the need for not persisting is less common?

kyranjamie commented 9 months ago

This is important as once apps have authenticated, another wallet provide may be called erroneously, owing to how they complete for the shared namespace.

janniks commented 9 months ago

+1 sort of agree here But will be breaking, as to get the old behavior, folks would need to call disconnect each time. (Which they may not know about). But seems like a good change 👍🏻