hirosystems / explorer

Explore transactions and accounts on the Stacks blockchain. Clone any contract and experiment in your browser with the Explorer sandbox.
https://explorer.hiro.so/
MIT License
141 stars 102 forks source link

Ordinals and Stacks NFTs not showing in Leather #1591

Closed DeeList closed 4 months ago

DeeList commented 6 months ago

The following inscriptions and STX NFTs are failing to appear in Leather:

https://api.hiro.so/ordinals/v1/inscriptions/a77c2fda458fc67028cb444b3b3fdcdf36b168d89ceb7286630d2fc76b21a714i476/content

https://api.hiro.so/ordinals/v1/inscriptions/fc7e21fc4e8140100f5913a0e0d6ce1675b73298ba97de65ef0130169369f3dci421/content

Examples of more STX NFT Collectibles that do not display:

SPQ5CEHETP8K4Q2FSNNK9ANMPAVBSA9NN86YSN59.stxstone SP1CE3NQXDKCJ2KEFFGCVFA5C196S9F0RRX93HY87.pizza-ninjas-on-sothebys SP25W1B7YX3F20S598J4EXEE9HZ0XHY6PNVTT6FA3.trajan-endorse-v0_1_0

These are reported issues to Leather for reference: https://github.com/leather-wallet/extension/issues/5236# https://github.com/leather-wallet/extension/issues/5302

hiro2

nft

andresgalante commented 6 months ago

Is this a wallet issue?

DeeList commented 6 months ago

Thanks, Andres. I've forwarded your reply.

brandonmarshall-tm commented 6 months ago

Perhaps we should split the Ordinals & Stacks issues into their own individual issues @DeeList?

Regarding the Stacks NFT issues, it looks to be more of an explorer issue.

For example I can see this Stacks NFT in my collections on Gamma: https://stacks.gamma.io/collections/pizza-ninjas-on-sothebys/2

But not in Hiro Explorer: https://explorer.hiro.so/token/SP1CE3NQXDKCJ2KEFFGCVFA5C196S9F0RRX93HY87.pizza-ninjas-on-sothebys?chain=mainnet

brandonmarshall-tm commented 6 months ago

Adding additional example of a Stacks NFT not showing in Hiro:

https://api.hiro.so/metadata/v1/nft/SP2XMGYYTA1KRBKBYJHTW8CFWB2QYZKZE4BMHG3PJ.honorary-mojo/26 https://stacks.gamma.io/collections/honorary-mojo/26

markmhendrickson commented 5 months ago

@DeeList let's split this issue into two for the Ordinals API and Stacks Blockchain API repos specifically, since it seems like we're dealing with missing data from each of these APIs?

The explorer would fail to show them (just as the wallet fails to show them) if it also can't retrieve data from the relevant API. So this wouldn't be an explorer issue per se.

brandonmarshall-tm commented 5 months ago

Here is another user report, basically none of these are displaying in Leather and also not displaying correctly in Hiro (but do display correctly on Gamma)

https://explorer.hiro.so/address/SP2QP89JZACDW214Q5H2N3WJWXV5N5GKMA7HNPZ41?chain=mainnet https://stacks.gamma.io/fortnakamoto.btc

brandonmarshall-tm commented 5 months ago

Created a new Stacks-specific issue for this: https://github.com/hirosystems/explorer/issues/1634

markmhendrickson commented 5 months ago

@brandonmarshall-tm it may be best to file all Hiro data-related issues in their API repo, since the wallet and explorer both pull from it?

brandonmarshall-tm commented 5 months ago

Cross-posted to https://github.com/hirosystems/token-metadata-api/issues/218

brandonmarshall-tm commented 5 months ago

I think this issue can be resolved! The only NFTs not showing are ones not following SIP-016 standard, but the main ones that were previously missing (like Nakamojo and Project Indigo) are displaying now.

DeeList commented 5 months ago

There are some older NFTs and newer like the Stacks original Nakamojo NFT https://explorer.hiro.so/txid/SPNWZ5V2TPWGQGVDR6T7B6RQ4XMGZ4PXTEE0VQ0S.mojo?chain=mainnet and Stacking DAO NFT https://explorer.hiro.so/txid/SP4SZE494VC2YC5JYG7AYFQ44F5Q4PYV7DVMDPBG.stacking-dao-genesis-nft?chain=mainnet that do not display in Leather but show in Gamma.

nfts nft2
DeeList commented 4 months ago

New issue opened Stacks-Blockchain-API