search

hirosystems / ordinals-api

Bitcoin Ordinals API
Apache License 2.0
201 stars 61 forks source link

Support for collections #40

Open diwakergupta opened 1 year ago

diwakergupta commented 1 year ago

Some sort of collections API will be useful for wallets (cc/ @markmhx ), marketplaces and others.

There's no canonical way of representing collections in an on-chain manner, yet. However, a lot of folks seem to be using this: https://github.com/ordinals-wallet/ordinals-collections

Other relevant resources:

markmhendrickson commented 1 year ago

Related wallet issue that this could power: https://github.com/hirosystems/wallet/issues/3561

smcclellan commented 1 year ago

We're blocked on https://github.com/casey/ord/issues/783 to complete, which will make this ticket much easier.

diwakergupta commented 1 year ago

We're blocked on casey/ord#783 to complete, which will make this ticket much easier.

Why is casey/ord#783 a blocker? I mean native collection support would be great no doubt, but just want to flag that people are already finding ways to move forward without our API. E.g. from https://github.com/hirosystems/wallet/issues/3613:

https://api.ordinalhub.com/docs

petehodl commented 1 year ago

@smcclellan @diwakergupta this would help us at Liquidium a ton!

A "simpler" solution of adding a collection property to the results of the /inscriptions endpoint would be incredibly useful to our product. Since there's not a perfect way of verifying collections, we were thinking of using that ordinals wallet repo you shared above too. Maybe it'd be best to only provide the collection info for the larger and well known collections? Just some thoughts.

If there is anyway we can support this development, we'd be glad to.

chresko commented 1 year ago

@rafaelcr Thoughts on supporting @petehodl proposal? Sounds reasonable to me.

rafaelcr commented 1 year ago

@chresko this could definitely be done, however, we'll need to integrate this third party dependency into our current API indexing flow, i.e. we would not only need to consume events from Chainhooks/hord but we'll need to read the external Ordinals Wallet github repo to get collection data so we can integrate it into API responses.

It would be a large task but definitely feasible.

chresko commented 1 year ago

Bumping this up to High.