search

hirosystems / stacks-blockchain-api

API for the Stacks blockchain
https://stacks-blockchain-api.vercel.app
GNU General Public License v3.0
177 stars 114 forks source link

Testnet faucet endpoint should respect multi-cast config #1003

Closed CharlieC3 closed 1 year ago

CharlieC3 commented 2 years ago

Describe the bug Currently, the faucet endpoint does use the multi-cast feature of the API. So faucet requests won't get multi-casted to overridden targets in the multi-cast configuration.

To Reproduce Steps to reproduce the behavior:

  1. Send a faucet request to a testnet API with multicast configured with multiple targets
  2. Observe the faucet request only gets routed to the default backend proxy stacks-node.

Expected behavior Testnet faucet requests should get routed to all targets configured in the mult-cast config file.

API version: 1.0.7

zone117x commented 1 year ago

We looks like we haven't ran into problems with this in a couple years (maybe due to improved mempool propagation in the stacks-node?). Going to close for now, please feel free to re-open.